[CI] Add remaining Ubuntu 24.04 Dockerfile#16457
Conversation
sarnex
changed the title
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
| @@ -0,0 +1,42 @@ | |||
| FROM nvidia/cuda:12.6.3-devel-ubuntu24.04 | |||
There was a problem hiding this comment.
The Ubuntu 22 docker container uses CUDA 12.1.0 (https://github.com/intel/llvm/blob/sycl/devops/containers/ubuntu2204_build.Dockerfile#L1). Are we good to use CUDA 12.6.3 with DPC++?
Similarly, Ubuntu 22 container uses ROCM 6.1.1 while Ubuntu 24 uses ROCM 6.3.
There was a problem hiding this comment.
Good question. Based on the Codeplay doc (who owns the AMD/NVidia support), they say CUDA12+ works but isn't the version they are currently testing on:
And for ROCM:
Here it doesn't list 6.3 specifically but says a wide variety should work. Also one of the runners is already using an unsupported GPU so it's not like we are following this doc today.
So IMO based on the doc I think it's fine to try to use the newer API versions but we can revert if there's some problem.
There was a problem hiding this comment.
Seems reasonable to me. @npmiller @JackAKirk FYI.
There was a problem hiding this comment.
I'm going to merge this for now. This PR doesn't make us use the new versions in testing yet, it just adds the Docker images. There will be a subsequent PR to move the CI over to use those new images. Happy to address any feedback from the Codeplay team.
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM overall, just one question.
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
3 participants
This adds the remaining Dockerfiles we'll need for Ubuntu 24.04.
There will be two more containers added to the workflow after this PR, I can't add them now because they require changes in this PR and CI doesn't use the files from precommit.